fix(security): vault integration secrets instead of plaintext config (R1)
PayPal client_secret (and any secret-named integration field) was stored plaintext in integrations.config, unlike Stripe/door which use the AES-256-GCM vault. A DB read or backup leaked it in cleartext. - lib/secrets/vault.ts: canonical generic storeSecret/readSecret + isSecretConfigField (the proven Stripe vault logic, generalized). - saveIntegration: secret-named fields go to the vault, only a *_ref is kept in config; blank submit preserves the ref (write-only like Stripe); legacy plaintext auto-migrates into the vault on next save. - paypal/sync reads client_secret from the vault, transitional fallback to legacy plaintext until the next save. - Docs updated (API_REFERENCE, ARCHITECTURE 10.3). 502 tests.
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
// Generic per-space secret vault helpers. This is the canonical store/read
|
||||
// pair for any third-party credential (the AES-256-GCM `secrets` table, the
|
||||
// same layout the door subsystem and Stripe config use). NOT a 'use server'
|
||||
// module: it takes a Supabase admin client and is imported by server actions
|
||||
// and route handlers. Secrets are server-only and never returned to a client.
|
||||
import type { createAdminClient } from '@/lib/supabase/admin'
|
||||
import { encryptSecret, decryptSecret, encryptionAvailable } from '@/lib/secrets/crypto'
|
||||
|
||||
type Admin = ReturnType<typeof createAdminClient>
|
||||
|
||||
// Store a credential in the encrypted vault. Returns the secret row id to
|
||||
// keep (as a *_ref) in integrations.config. null on failure.
|
||||
export async function storeSecret(
|
||||
admin: Admin,
|
||||
spaceId: string,
|
||||
title: string,
|
||||
value: string,
|
||||
createdBy: string | null,
|
||||
): Promise<string | null> {
|
||||
const row: Record<string, unknown> = {
|
||||
space_id: spaceId,
|
||||
title,
|
||||
label: title,
|
||||
category: 'integration',
|
||||
created_by: createdBy,
|
||||
}
|
||||
if (encryptionAvailable()) {
|
||||
const { ciphertext, version } = encryptSecret(value)
|
||||
row.encrypted_value = ciphertext
|
||||
row.encryption_version = version
|
||||
row.value = ''
|
||||
} else {
|
||||
row.value = value
|
||||
row.encryption_version = 0
|
||||
}
|
||||
const { data, error } = await admin.from('secrets').insert(row).select('id').single()
|
||||
if (error || !data) return null
|
||||
return data.id as string
|
||||
}
|
||||
|
||||
// Read + decrypt a stored credential by ref, space-scoped. Server-only.
|
||||
export async function readSecret(
|
||||
admin: Admin,
|
||||
spaceId: string,
|
||||
secretRef: string | null | undefined,
|
||||
): Promise<string | null> {
|
||||
if (!secretRef) return null
|
||||
const { data } = await admin
|
||||
.from('secrets')
|
||||
.select('encryption_version, encrypted_value, value')
|
||||
.eq('id', secretRef)
|
||||
.eq('space_id', spaceId)
|
||||
.maybeSingle()
|
||||
if (!data) return null
|
||||
if (data.encryption_version === 1 && data.encrypted_value) {
|
||||
const raw = data.encrypted_value as unknown
|
||||
const buf =
|
||||
typeof raw === 'string'
|
||||
? Buffer.from((raw as string).replace(/^\\x/, ''), 'hex')
|
||||
: Buffer.from(raw as Uint8Array)
|
||||
try {
|
||||
return decryptSecret(buf, 1)
|
||||
} catch {
|
||||
return null
|
||||
}
|
||||
}
|
||||
return (data.value as string | null) ?? null
|
||||
}
|
||||
|
||||
// Config key naming convention for credentials that must be vaulted rather
|
||||
// than stored plaintext in integrations.config. Derived keys (*_set, *_ref)
|
||||
// are never themselves secrets.
|
||||
export function isSecretConfigField(key: string): boolean {
|
||||
if (key.endsWith('_set') || key.endsWith('_ref')) return false
|
||||
return (
|
||||
key === 'client_secret' ||
|
||||
key === 'api_key' ||
|
||||
key === 'secret_key' ||
|
||||
key.endsWith('_secret')
|
||||
)
|
||||
}
|
||||
Reference in New Issue
Block a user