test(forms): extract pure decision logic and add exhaustive coverage

The forms security/correctness logic was buried in DB-coupled server
actions and the builder component, so it had no real tests (the suite
is pure-logic only; nothing exercises Supabase). Extract the pure
parts behaviour-unchanged into lib/forms-logic.ts and test them for
real:

- csvCell (results-export escaping), parseClientIp (e-sign IP capture
  filtering), shouldBumpFormVersion (waiver non-blocking re-sign),
  evaluateRequiredFormStep (onboarding required/auto-satisfy/fail-open),
  slugify + deriveFieldKeys (builder key derivation + dedupe)
- forms.ts / onboarding.ts / form-builder.tsx now consume these; the
  local copies are removed (no behaviour change — verified by the full
  suite staying green)
- __tests__/forms.test.ts expanded 16 -> 62: every validateAnswers
  type/branch (type coercion, length caps, required, unknown-key
  stripping, first-error ordering), parseFormSchema, every new Zod
  schema incl. formSlug boundaries, and all extracted helpers

333/333 tests; build verified (Compiled successfully, exit 0). No deploy.
This commit is contained in:
Moheeb Zara
2026-05-16 16:40:09 -07:00
parent 40d4cdad98
commit 5c39317877
5 changed files with 564 additions and 138 deletions
+29 -17
View File
@@ -10,6 +10,7 @@ import {
uuidSchema,
} from '@/lib/validations'
import { claimMyAnonymousSubmissions } from './forms'
import { evaluateRequiredFormStep } from '@/lib/forms-logic'
const ONBOARDING_ADMIN_ROLES = ['admin', 'board'] as const
@@ -184,23 +185,34 @@ export async function finishOnboarding() {
return { error: 'Please complete the required steps before finishing.' }
}
const formId = (s.config as { form_id?: string } | null)?.form_id
if (!formId) continue
const { data: form } = await supabase
.from('forms')
.select('id, status')
.eq('id', formId)
.eq('space_id', member.space_id)
.maybeSingle()
if (!form || form.status !== 'published') continue
const { count } = await admin
.from('form_submissions')
.select('id', { count: 'exact', head: true })
.eq('form_id', formId)
.eq('space_id', member.space_id)
.eq('member_id', member.id)
if ((count ?? 0) === 0) {
let formPublished = false
let submissionExists = false
if (formId) {
const { data: form } = await supabase
.from('forms')
.select('id, status')
.eq('id', formId)
.eq('space_id', member.space_id)
.maybeSingle()
formPublished = !!form && form.status === 'published'
if (formPublished) {
const { count } = await admin
.from('form_submissions')
.select('id', { count: 'exact', head: true })
.eq('form_id', formId)
.eq('space_id', member.space_id)
.eq('member_id', member.id)
submissionExists = (count ?? 0) > 0
}
}
if (
evaluateRequiredFormStep({
stepType: s.step_type,
formId,
formPublished,
submissionExists,
}) === 'block'
) {
return { error: 'Please complete the required form before finishing.' }
}
}