notifications(P4b): equipment booking confirmed + cancelled emails
reserveEquipment now enqueues a booking_confirmed email to the booked-for member (always; a manager booking on someone else's behalf still emails the target). cancelReservation enqueues a booking_cancelled email ONLY when the actor is not the affected member, so self-cancels stay silent. Adds renderBookingEmail + bookingDedupeKey to lib/notifications-logic.ts (extracts a shared renderShell at the same time so the 6 upcoming templates do not duplicate the HTML wrapper). 6 new render/dedupe unit tests cover subject lines, range + location lines, fallback copy when names are missing, and HTML escaping of injected names. Suite 550, build clean. No schema change (the notifications.type column is text), no dispatcher change.
This commit is contained in:
@@ -6,6 +6,8 @@ import {
|
||||
duesDedupeKey,
|
||||
formatMoney,
|
||||
renderDuesEmail,
|
||||
bookingDedupeKey,
|
||||
renderBookingEmail,
|
||||
} from '@/lib/notifications-logic'
|
||||
|
||||
describe('isTerminalAttempt', () => {
|
||||
@@ -154,3 +156,69 @@ describe('renderDuesEmail', () => {
|
||||
expect(r.text).toContain('Hi,')
|
||||
})
|
||||
})
|
||||
|
||||
describe('bookingDedupeKey', () => {
|
||||
it('keys by type + reservation id; per-reservation per-event', () => {
|
||||
expect(bookingDedupeKey('booking_confirmed', 'r1')).toBe('booking_confirmed:r1')
|
||||
expect(bookingDedupeKey('booking_cancelled', 'r1')).toBe('booking_cancelled:r1')
|
||||
expect(bookingDedupeKey('booking_confirmed', 'r1')).not.toBe(
|
||||
bookingDedupeKey('booking_confirmed', 'r2'),
|
||||
)
|
||||
})
|
||||
})
|
||||
|
||||
describe('renderBookingEmail', () => {
|
||||
const base = {
|
||||
spaceName: 'Acme',
|
||||
memberName: 'Ada',
|
||||
equipmentName: 'Laser Cutter',
|
||||
location: 'Bay 3',
|
||||
startsAt: '2026-05-22T15:00:00Z',
|
||||
endsAt: '2026-05-22T17:00:00Z',
|
||||
manageUrl: 'https://x.test/me',
|
||||
} as const
|
||||
|
||||
it('confirmed: subject names equipment + space; body has range, location, link', () => {
|
||||
const r = renderBookingEmail({ type: 'booking_confirmed', ...base })
|
||||
expect(r.subject).toBe('Reservation confirmed: Laser Cutter at Acme')
|
||||
expect(r.text).toContain('Hi Ada,')
|
||||
expect(r.text).toContain('Laser Cutter at Acme')
|
||||
expect(r.text).toContain('Bay 3')
|
||||
expect(r.text).toContain('https://x.test/me')
|
||||
expect(r.html).toContain('<a href="https://x.test/me"')
|
||||
})
|
||||
|
||||
it('cancelled: subject + body acknowledge the cancel', () => {
|
||||
const r = renderBookingEmail({ type: 'booking_cancelled', ...base })
|
||||
expect(r.subject).toBe('Reservation cancelled: Laser Cutter at Acme')
|
||||
expect(r.text.toLowerCase()).toContain('was cancelled')
|
||||
})
|
||||
|
||||
it('omits the location line when not provided', () => {
|
||||
const r = renderBookingEmail({ ...base, type: 'booking_confirmed', location: null })
|
||||
expect(r.text).not.toContain('Location:')
|
||||
})
|
||||
|
||||
it('falls back to a generic greeting + equipment label when names missing', () => {
|
||||
const r = renderBookingEmail({
|
||||
...base,
|
||||
type: 'booking_confirmed',
|
||||
memberName: '',
|
||||
equipmentName: '',
|
||||
})
|
||||
expect(r.text).toContain('Hi,')
|
||||
expect(r.subject).toBe('Reservation confirmed: the equipment at Acme')
|
||||
})
|
||||
|
||||
it('escapes HTML in injected names', () => {
|
||||
const r = renderBookingEmail({
|
||||
...base,
|
||||
type: 'booking_confirmed',
|
||||
memberName: 'a<b>',
|
||||
equipmentName: '<img>',
|
||||
})
|
||||
expect(r.html).not.toContain('<img>')
|
||||
expect(r.html).toContain('<img>')
|
||||
expect(r.html).toContain('a<b>')
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user