feat(classes): optional required-form gate at signup (waiver-on-file)

Pure signupFormEligibility (manager override bypasses) + 4 tests.
signUpForClass now: classes.manage override + sign-up-on-behalf
(targetMemberId), and a hard form gate -- if the class has a
required_form_id the member must have a form_submissions row on file
(checked via service client, since a class manager need not hold
forms.manage). create/updateClass validate the form is in-space and
published. listUpcomingSessions exposes required_form {title,url,
satisfied}. Manage UI: published-form picker on create/edit + a 'requires
form' badge. Member UI: shows the requirement, links to the form, and
replaces Sign up with 'Complete required form' until it is on file.
Mirrors the equipment cert-gate pattern.
This commit is contained in:
Moheeb Zara
2026-05-16 21:41:01 -07:00
parent 92c5737a25
commit f3b05afe14
7 changed files with 259 additions and 16 deletions
@@ -22,6 +22,7 @@ type Row = {
classes: { title: string; description: string | null; payment_link: string | null; capacity: number | null } | Array<{ title: string; description: string | null; payment_link: string | null; capacity: number | null }> | null
registered_count: number
my_status: string | null
required_form: { title: string; url: string | null; satisfied: boolean } | null
}
function classOf(r: Row) {
@@ -97,6 +98,7 @@ export function ClassesBrowseClient({
const cap = effectiveCapacity(r.capacity, c?.capacity ?? null)
const spots = cap == null ? null : Math.max(0, cap - r.registered_count)
const full = cap != null && r.registered_count >= cap
const formBlocked = !r.my_status && !!r.required_form && !r.required_form.satisfied
return (
<li key={r.id} className="rounded-lg border border-border p-4">
<div className="flex items-start justify-between gap-4 flex-wrap">
@@ -116,6 +118,21 @@ export function ClassesBrowseClient({
{r.location ? ` · ${r.location}` : ''}
{cap == null ? ' · open' : ` · ${spots} of ${cap} spots left`}
</p>
{r.required_form && (
<p className={`font-mono text-[10px] mt-1 ${r.required_form.satisfied ? 'text-muted-foreground' : 'text-amber-600'}`}>
{r.required_form.satisfied
? `Required form on file: ${r.required_form.title}`
: `Requires the "${r.required_form.title}" form before signup`}
{!r.required_form.satisfied && r.required_form.url && (
<>
{' · '}
<a href={r.required_form.url} target="_blank" rel="noopener noreferrer" className="text-primary underline">
complete it
</a>
</>
)}
</p>
)}
{r.notes && <p className="font-sans text-xs text-muted-foreground mt-1">{r.notes}</p>}
{c?.payment_link && (
<a href={c.payment_link} target="_blank" rel="noopener noreferrer"
@@ -131,6 +148,19 @@ export function ClassesBrowseClient({
>
Cancel signup
</button>
) : formBlocked ? (
r.required_form?.url ? (
<a
href={r.required_form.url}
target="_blank"
rel="noopener noreferrer"
className="font-mono text-[10px] border border-amber-500 text-amber-600 px-3 py-2 rounded hover:bg-amber-50 transition"
>
Complete required form
</a>
) : (
<span className="font-mono text-[10px] text-amber-600 px-3 py-2">Form required</span>
)
) : (
<button
onClick={() => onSignUp(r)}
@@ -26,6 +26,7 @@ type Cls = {
capacity: number | null
is_active: boolean
grants_certification_id: string | null
required_form_id: string | null
}
type Session = {
id: string
@@ -38,12 +39,13 @@ type Session = {
notes: string | null
}
type Cert = { id: string; name: string; is_active: boolean }
type Form = { id: string; title: string; kind: string }
const inputCls =
'w-full bg-background border border-border text-foreground font-sans text-sm rounded px-3 py-2 focus:outline-none focus:border-primary'
function emptyClassDraft() {
return { title: '', description: '', payment_link: '', capacity: '', grants_certification_id: '' }
return { title: '', description: '', payment_link: '', capacity: '', grants_certification_id: '', required_form_id: '' }
}
function emptySessionDraft() {
return { starts_at: '', ends_at: '', location: '', capacity: '', notes: '' }
@@ -59,10 +61,12 @@ export function ClassesManageClient({
initialClasses,
initialSessions,
certs,
forms,
}: {
initialClasses: Cls[]
initialSessions: Session[]
certs: Cert[]
forms: Form[]
}) {
const confirm = useConfirm()
const [classes, setClasses] = useState<Cls[]>(initialClasses)
@@ -78,6 +82,9 @@ export function ClassesManageClient({
function certName(id: string | null) {
return id ? certs.find(c => c.id === id)?.name ?? null : null
}
function formName(id: string | null) {
return id ? forms.find(f => f.id === id)?.title ?? null : null
}
async function onCreate(e: React.FormEvent) {
e.preventDefault()
@@ -89,6 +96,7 @@ export function ClassesManageClient({
payment_link: draft.payment_link.trim() || null,
capacity: num(draft.capacity),
grants_certification_id: draft.grants_certification_id || null,
required_form_id: draft.required_form_id || null,
})
setBusy(false)
if ('error' in res && res.error) return toast.error(res.error)
@@ -102,6 +110,7 @@ export function ClassesManageClient({
capacity: num(draft.capacity),
is_active: true,
grants_certification_id: draft.grants_certification_id || null,
required_form_id: draft.required_form_id || null,
},
...prev,
])
@@ -118,6 +127,7 @@ export function ClassesManageClient({
payment_link: c.payment_link ?? '',
capacity: c.capacity == null ? '' : String(c.capacity),
grants_certification_id: c.grants_certification_id ?? '',
required_form_id: c.required_form_id ?? '',
})
}
@@ -131,6 +141,7 @@ export function ClassesManageClient({
payment_link: editDraft.payment_link.trim() || null,
capacity: num(editDraft.capacity),
grants_certification_id: editDraft.grants_certification_id || null,
required_form_id: editDraft.required_form_id || null,
})
setBusy(false)
if ('error' in res && res.error) return toast.error(res.error)
@@ -144,6 +155,7 @@ export function ClassesManageClient({
payment_link: editDraft.payment_link.trim() || null,
capacity: num(editDraft.capacity),
grants_certification_id: editDraft.grants_certification_id || null,
required_form_id: editDraft.required_form_id || null,
}
: c,
),
@@ -260,7 +272,17 @@ export function ClassesManageClient({
<option value="">Grants no certification</option>
{certs.map(c => <option key={c.id} value={c.id}>Grants: {c.name}</option>)}
</select>
<select className={inputCls} value={draft.required_form_id}
onChange={e => setDraft({ ...draft, required_form_id: e.target.value })}>
<option value="">No required form</option>
{forms.map(f => <option key={f.id} value={f.id}>Requires: {f.title}{f.kind === 'waiver' ? ' (waiver)' : ''}</option>)}
</select>
</div>
{forms.length === 0 && (
<p className="font-mono text-[10px] text-muted-foreground">
Tip: publish a form under Forms to be able to require it (e.g. a liability waiver) before signup.
</p>
)}
<Button type="submit" size="sm" disabled={busy}>Create class</Button>
</form>
)}
@@ -297,6 +319,11 @@ export function ClassesManageClient({
<option value="">Grants no certification</option>
{certs.map(x => <option key={x.id} value={x.id}>Grants: {x.name}</option>)}
</select>
<select className={inputCls} value={editDraft.required_form_id}
onChange={e => setEditDraft({ ...editDraft, required_form_id: e.target.value })}>
<option value="">No required form</option>
{forms.map(f => <option key={f.id} value={f.id}>Requires: {f.title}{f.kind === 'waiver' ? ' (waiver)' : ''}</option>)}
</select>
</div>
<div className="flex gap-2">
<Button size="sm" disabled={busy} onClick={() => onSaveEdit(c.id)}>Save</Button>
@@ -313,6 +340,9 @@ export function ClassesManageClient({
{certName(c.grants_certification_id) && (
<span className="font-mono text-[10px] text-primary">grants {certName(c.grants_certification_id)}</span>
)}
{formName(c.required_form_id) && (
<span className="font-mono text-[10px] text-amber-600">requires form: {formName(c.required_form_id)}</span>
)}
</div>
{c.description && <p className="font-sans text-sm text-muted-foreground mt-1">{c.description}</p>}
{c.payment_link && (
+9 -2
View File
@@ -6,10 +6,10 @@ export const dynamic = 'force-dynamic'
export default async function ClassesManagePage() {
const { supabase, member } = await requireClassesManagerPage()
const [{ data: classes }, { data: sessions }, { data: certs }] = await Promise.all([
const [{ data: classes }, { data: sessions }, { data: certs }, { data: forms }] = await Promise.all([
supabase
.from('classes')
.select('id, title, description, payment_link, capacity, is_active, grants_certification_id, created_at, updated_at')
.select('id, title, description, payment_link, capacity, is_active, grants_certification_id, required_form_id, created_at, updated_at')
.eq('space_id', member.space_id)
.order('is_active', { ascending: false })
.order('title', { ascending: true }),
@@ -24,6 +24,12 @@ export default async function ClassesManagePage() {
.eq('space_id', member.space_id)
.eq('is_active', true)
.order('name', { ascending: true }),
supabase
.from('forms')
.select('id, title, kind')
.eq('space_id', member.space_id)
.eq('status', 'published')
.order('title', { ascending: true }),
])
return (
@@ -31,6 +37,7 @@ export default async function ClassesManagePage() {
initialClasses={classes ?? []}
initialSessions={sessions ?? []}
certs={certs ?? []}
forms={forms ?? []}
/>
)
}