feat: comprehensive application audit and fixes

Audited codebase, fixed input validation, OAuth, error handling, type casts, and security hardening

Co-authored-by: Moheeb Zara <1184415+virgilvox@users.noreply.github.com>

app/(app)/error.tsx

@@ -0,0 +1,61 @@
+'use client'
+
+import { useEffect } from 'react'
+import { AlertTriangle, RefreshCw, ArrowLeft } from 'lucide-react'
+import Link from 'next/link'
+
+export default function AppError({
+  error,
+  reset,
+}: {
+  error: Error & { digest?: string }
+  reset: () => void
+}) {
+  useEffect(() => {
+    console.error('[App Section Error]', error)
+  }, [error])
+
+  return (
+    <div className="flex-1 flex items-center justify-center p-8">
+      <div className="max-w-md w-full">
+        <div className="bg-card border border-border rounded-lg p-6 text-center">
+          <div className="w-12 h-12 rounded-full bg-destructive/10 flex items-center justify-center mx-auto mb-4">
+            <AlertTriangle className="w-6 h-6 text-destructive" />
+          </div>
+          
+          <h2 className="text-lg font-semibold text-foreground mb-2">
+            Something went wrong
+          </h2>
+          
+          <p className="text-sm text-muted-foreground mb-4">
+            We encountered an error while loading this page.
+          </p>
+
+          {error.digest && (
+            <p className="text-xs text-muted-foreground/60 font-mono mb-4 bg-muted px-2 py-1 rounded inline-block">
+              {error.digest}
+            </p>
+          )}
+
+          <div className="flex gap-2 justify-center">
+            <button
+              onClick={reset}
+              className="inline-flex items-center gap-1.5 px-3 py-2 rounded-md bg-primary text-primary-foreground text-sm font-medium hover:bg-primary/90 transition-colors"
+            >
+              <RefreshCw className="w-3.5 h-3.5" />
+              Retry
+            </button>
+            
+            <Link
+              href="/dashboard"
+              className="inline-flex items-center gap-1.5 px-3 py-2 rounded-md border border-border text-foreground text-sm font-medium hover:bg-accent transition-colors"
+            >
+              <ArrowLeft className="w-3.5 h-3.5" />
+              Dashboard
+            </Link>
+          </div>
+        </div>
+      </div>
+    </div>
+  )
+}

app/(app)/layout.tsx

@@ -41,7 +41,7 @@ export default async function AppLayout({ children }: { children: React.ReactNod
   return (
     <div className="flex h-screen bg-background overflow-hidden">
       <AppSidebar
-        member={member as any}
+        member={member}
         taskBadge={taskCount ?? 0}
         paymentBadge={paymentCount ?? 0}
       />

app/(app)/loading.tsx

@@ -0,0 +1,12 @@
+import { Loader2 } from 'lucide-react'
+
+export default function AppLoading() {
+  return (
+    <div className="flex-1 flex items-center justify-center min-h-[50vh]">
+      <div className="flex flex-col items-center gap-3">
+        <Loader2 className="w-8 h-8 text-primary animate-spin" />
+        <p className="text-sm text-muted-foreground font-mono">Loading...</p>
+      </div>
+    </div>
+  )
+}

app/(app)/ops/page.tsx

@@ -1,5 +1,6 @@
 import { createClient } from '@/lib/supabase/server'
 import { OpsClient } from './ops-client'
+import type { Tables } from '@/types/database'
 
 export default async function OpsPage() {
   const supabase = await createClient()
@@ -16,17 +17,17 @@ export default async function OpsPage() {
     supabase.from('knowledge_base').select('*').eq('space_id', member.space_id).order('is_pinned', { ascending: false }).order('created_at', { ascending: false }),
     supabase.from('area_leads').select('*').eq('space_id', member.space_id).order('area_name'),
     canSeeSecrets
-      ? supabase.from('secrets').select('id, title, area, created_at').eq('space_id', member.space_id)
-      : Promise.resolve({ data: [] }),
+      ? supabase.from('secrets').select('id, title, area, created_at, label, value, description, icon, space_id, created_by, updated_at, category, notes').eq('space_id', member.space_id)
+      : Promise.resolve({ data: [] as Tables<'secrets'>[] }),
   ])
 
   return (
     <OpsClient
-      member={member}
+      member={member as Tables<'space_members'>}
       spaceId={member.space_id}
       kbEntries={kbEntries ?? []}
       areaLeads={areaLeads ?? []}
-      secrets={(secretsResult as any)?.data ?? []}
+      secrets={secretsResult.data ?? []}
       canSeeSecrets={canSeeSecrets}
     />
   )